Pipelines Stage: BETWEEN, tests and mod

[Jeff Hennick-3]

I have been working with the Pipelines builtin stages (again).

I have been creating a comprehensive (I hope) test suite for each with all its options.  I am also comparing them to the CMS Pipelines User's Guide and Reference V6R4.  And as a result, have some updates for some stages.

For example, for the BETWEEN stage there are 11 tests similar to this: [note: your email agent may wrap long lines]

-- between /string/ number ?
   literal first one;second one;third one;fourth one;fifth one;sixth one;seventh one;eighth one  |
   split ; |
   between /third/ 2 | -- actual test stage |
   c5: compare any ~2# 5 between /string/ number~ equal ~*OK*~ notequal ~**FAIL**  at rec \\c col \\b.~ less /Less:\nActual:\n\\p\nExpected:\n\\s\n/ more /More:\nActual:\n\\p\nExpected:\n\\s\n/ |
   o: ?
   literal third one;fourth one; | -- expected results |
   split ; |
   c5: ?

[The o: ? stage collects the outputs from all the tests and formats them.]

These tests for BETWEEN are collected into a single .njp pipe file, with some documentation.  For BETWEEN, there are actually 14 tests because the current version fails 3 tests, the new one passes all.

When compiled and run, it looks like this:

C:\Users\Jeff\Documents\Pipe Tests>java between_tests_new #0 #1 ################################################ #2 The 99/05/09 version of between.nrx does not cover CASELESS. It was added to CMS later. #3 Also a change in NetRexx causes problems with CASEIGNORE and IGNORECASE. This fix too is in between_new.nrx. #4 All between tests are OK with that version. #5 Jeff Hennick 19/09/16 #6 ################################################ #7 # 1 between /string/ /string/ *OK* # 2 between anycase /string1/ /string2/ *OK* # 3 between anycase /string/ number *OK* # 4 between /string/ number (none) *OK* # 5 between /string/ number *OK* # 6 between /string/ number (multi) *OK* # 7 between // number *OK* # 8 between caseany /string/ number *OK* # 9 between caseignore /string/ number **FAIL** netrexx.lang.NotLogicException: Boolean must be 0 or 1. Found: 3 # 9_new between caseignore /string/ number (between_new) *OK* #10 between caseless /string/ number (between) **FAIL** between_78 Error - between_78 No "toLabel" rc=11 #10_new between caseless /string/ number (between_new) *OK* #11 between caseignore /string/ number **FAIL** netrexx.lang.NotLogicException: Boolean must be 0 or 1. Found: 2 #11_new between ignorecase /string/ number (between_new) *OK* C:\Users\Jeff\Documents\Pipe Tests>

Here, because the failures cause runtime errors, I have actually put them in as comments.  In cases where simply the output is wrong, it and the expected value are displayed.  The repeated tests then use the new version of BETWEEN.  (Separately, all the tests have been run with the new version, and all pass.)

I have two versions of the test pipe.  The one above, between_tests_new.njp and a similar one, between_tests.njp without the second, "_new", tests.  It is this version that I think should be published along with the new version of the stage between.nrx.

Actually I have not been able to test that new stage version with it's real name.  Java/NetRexx complains that there are multiple versions of the between class.  So I have named the new version between_new.nrx.  It also has the package statement commented out, as it causes errors in testing.  I do have and almost identical file, between.nrx, with the "right names," and package statement ready for publication; I have not been able to actually test it.  I believe the package statement, package org.netrexx.njpipes.stages, is correct, but maybe things have changed.

Bottom line: I have 4 files ready for submission.  Two with "_new" suffixes for testing, and two without probably ready for publication.

What is the best way to proceed and submit these?  (Recognizing that I have several more such sets nearly ready to go.)

Jeff

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[rvjansen]

Hi Jeff,

If you have a SourceForge id, I’ll grant you committer privileges so you’ll be able to jsut push changes to the source cose repository. That seems the best way going forward.

René.

On 24 Oct 2019, at 19:26, Jeff Hennick <[hidden email]> wrote:



I have been working with the Pipelines builtin stages (again).

I have been creating a comprehensive (I hope) test suite for each with all its options.  I am also comparing them to the CMS Pipelines User's Guide and Reference V6R4.  And as a result, have some updates for some stages.

For example, for the BETWEEN stage there are 11 tests similar to this: [note: your email agent may wrap long lines]

-- between /string/ number ?
   literal first one;second one;third one;fourth one;fifth one;sixth one;seventh one;eighth one  |
   split ; |
   between /third/ 2 | -- actual test stage |
   c5: compare any ~2# 5 between /string/ number~ equal ~*OK*~ notequal ~**FAIL**  at rec \\c col \\b.~ less /Less:\nActual:\n\\p\nExpected:\n\\s\n/ more /More:\nActual:\n\\p\nExpected:\n\\s\n/ |
   o: ?
   literal third one;fourth one; | -- expected results |
   split ; |
   c5: ?

[The o: ? stage collects the outputs from all the tests and formats them.]

These tests for BETWEEN are collected into a single .njp pipe file, with some documentation.  For BETWEEN, there are actually 14 tests because the current version fails 3 tests, the new one passes all.

When compiled and run, it looks like this:

C:\Users\Jeff\Documents\Pipe Tests>java between_tests_new #0 #1 ################################################ #2 The 99/05/09 version of between.nrx does not cover CASELESS. It was added to CMS later. #3 Also a change in NetRexx causes problems with CASEIGNORE and IGNORECASE. This fix too is in between_new.nrx. #4 All between tests are OK with that version. #5 Jeff Hennick 19/09/16 #6 ################################################ #7 # 1 between /string/ /string/ *OK* # 2 between anycase /string1/ /string2/ *OK* # 3 between anycase /string/ number *OK* # 4 between /string/ number (none) *OK* # 5 between /string/ number *OK* # 6 between /string/ number (multi) *OK* # 7 between // number *OK* # 8 between caseany /string/ number *OK* # 9 between caseignore /string/ number **FAIL** netrexx.lang.NotLogicException: Boolean must be 0 or 1. Found: 3 # 9_new between caseignore /string/ number (between_new) *OK* #10 between caseless /string/ number (between) **FAIL** between_78 Error - between_78 No "toLabel" rc=11 #10_new between caseless /string/ number (between_new) *OK* #11 between caseignore /string/ number **FAIL** netrexx.lang.NotLogicException: Boolean must be 0 or 1. Found: 2 #11_new between ignorecase /string/ number (between_new) *OK* C:\Users\Jeff\Documents\Pipe Tests>

Here, because the failures cause runtime errors, I have actually put them in as comments.  In cases where simply the output is wrong, it and the expected value are displayed.  The repeated tests then use the new version of BETWEEN.  (Separately, all the tests have been run with the new version, and all pass.)

I have two versions of the test pipe.  The one above, between_tests_new.njp and a similar one, between_tests.njp without the second, "_new", tests.  It is this version that I think should be published along with the new version of the stage between.nrx.

Actually I have not been able to test that new stage version with it's real name.  Java/NetRexx complains that there are multiple versions of the between class.  So I have named the new version between_new.nrx.  It also has the package statement commented out, as it causes errors in testing.  I do have and almost identical file, between.nrx, with the "right names," and package statement ready for publication; I have not been able to actually test it.  I believe the package statement, package org.netrexx.njpipes.stages, is correct, but maybe things have changed.

Bottom line: I have 4 files ready for submission.  Two with "_new" suffixes for testing, and two without probably ready for publication.

What is the best way to proceed and submit these?  (Recognizing that I have several more such sets nearly ready to go.)

Jeff

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/