Patch for netrexx-mode.el (Emacs)

[Marc Simpson]

Hi all,

I'd like to submit a simple patch for the latest revision (r188) of
netrexx-mode.el. It addresses the following issues,

* Highlighting for keyword: 'uses'
* Highlighting for classes in the 'uses' list (copied from 'implements')
* Font locking improvement for class names:
** Highlight all non-whitespace characters;
** Previously, minor class names were only highlighted up to the first period.
* Font-locking improvement for method instructions:
** Highlight all valid word constituent characters (don't delimit with
the left paren).
** Method names that aren't followed parentheses are now highlighted properly.
* Comment characters: prefer "-- " over the pair "/*" "*/":
** Seems to be in keeping with NetRexx style.
** Commenting a region will therefore prefix "-- " instead of
surrounding each line with /* ... */
* Toggle skeleton-mode via the (previously unused)
`netrexx-use-skeleton-pairing' variable.

As I'm not sure whether attachments are permitted, I've uploaded the
patch here: http://pastebin.com/gUH1cmV7 .

All the best,
M

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[Marc Simpson]

On Wed, Jan 18, 2012 at 11:26 AM, Marc Simpson <[hidden email]> wrote:
> Hi all,
>
> I'd like to submit a simple patch for the latest revision (r188) of
> netrexx-mode.el. It addresses the following issues,
> [...]

Slightly improved version here: http://pastebin.com/fbTA2GWB

M

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[ThSITC]

Hello Marc,
    1.) thanks for your patch. As I don't use Emacs, I currently cannot
use it.
    2.) would you mind, next time, to give a two-line description what
you're doing there?

Greetings, and thanks in advance,
Thomas.
=========================================================================
Am 18.01.2012 22:32, schrieb Marc Simpson:

> On Wed, Jan 18, 2012 at 11:26 AM, Marc Simpson<[hidden email]>  wrote:
>> Hi all,
>>
>> I'd like to submit a simple patch for the latest revision (r188) of
>> netrexx-mode.el. It addresses the following issues,
>> [...]
> Slightly improved version here: http://pastebin.com/fbTA2GWB
>
> M
>
> _______________________________________________
> Ibm-netrexx mailing list
> [hidden email]
> Online Archive : http://ibm-netrexx.215625.n3.nabble.com/
>
>

--
Thomas Schneider (Founder of www.thsitc.com) Member of the Rexx Languge
Asscociation (www.rexxla.org) Member of the NetRexx Developer's Team
(www.netrexx.org)

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[Marc Simpson]

Hi Thomas,

On Wed, Jan 18, 2012 at 10:13 PM, Thomas Schneider
<[hidden email]> wrote:
> Hello Marc,
>   1.) thanks for your patch. As I don't use Emacs, I currently cannot use
> it.
>   2.) would you mind, next time, to give a two-line description what you're
> doing there?

There's quite a detailed change summary in my original post; the
second version just tweaks whitespace recognition in the regular
expressions for method and class names.

Best,
M


_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[ThSITC]

Ok, Marc, just had a very short look at it, and did see a lot of
back-slashes only
Issue closed (from my side)
Thomas.
=================================================================
Am 18.01.2012 23:21, schrieb Marc Simpson:

> Hi Thomas,
>
> On Wed, Jan 18, 2012 at 10:13 PM, Thomas Schneider
> <[hidden email]>  wrote:
>> Hello Marc,
>>    1.) thanks for your patch. As I don't use Emacs, I currently cannot use
>> it.
>>    2.) would you mind, next time, to give a two-line description what you're
>> doing there?
> There's quite a detailed change summary in my original post; the
> second version just tweaks whitespace recognition in the regular
> expressions for method and class names.
>
> Best,
> M
>
>
> _______________________________________________
> Ibm-netrexx mailing list
> [hidden email]
> Online Archive : http://ibm-netrexx.215625.n3.nabble.com/
>
>

--
Thomas Schneider (Founder of www.thsitc.com) Member of the Rexx Languge
Asscociation (www.rexxla.org) Member of the NetRexx Developer's Team
(www.netrexx.org)

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[Marc Simpson]

On Wed, Jan 18, 2012 at 10:50 PM, Thomas Schneider
<[hidden email]> wrote:
> Ok, Marc, just had a very short look at it, and did see a lot of
> back-slashes only
> Issue closed (from my side)

Which issue? I don't follow...

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[rvjansen]

Hi Marc,

as I almost exclusively edit NetRexx using Emacs, I am very interested in using this improvement. Could you send me a private email with the whole file attached? The patch does not apply well. I'll check it in when I get it so it can still make RC3.

many thanks, and best regards,

René Jansen.

On 18 jan. 2012, at 12:26, Marc Simpson wrote:

> Hi all,
>
> I'd like to submit a simple patch for the latest revision (r188) of
> netrexx-mode.el. It addresses the following issues,
>
> * Highlighting for keyword: 'uses'
> * Highlighting for classes in the 'uses' list (copied from 'implements')
> * Font locking improvement for class names:
> ** Highlight all non-whitespace characters;
> ** Previously, minor class names were only highlighted up to the first period.
> * Font-locking improvement for method instructions:
> ** Highlight all valid word constituent characters (don't delimit with
> the left paren).
> ** Method names that aren't followed parentheses are now highlighted properly.
> * Comment characters: prefer "-- " over the pair "/*" "*/":
> ** Seems to be in keeping with NetRexx style.
> ** Commenting a region will therefore prefix "-- " instead of
> surrounding each line with /* ... */
> * Toggle skeleton-mode via the (previously unused)
> `netrexx-use-skeleton-pairing' variable.
>
> As I'm not sure whether attachments are permitted, I've uploaded the
> patch here: http://pastebin.com/gUH1cmV7 .
>
> All the best,
> M
>
> _______________________________________________
> Ibm-netrexx mailing list
> [hidden email]
> Online Archive : http://ibm-netrexx.215625.n3.nabble.com/
>

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[rvjansen]

Thomas,

when you do not use Emacs there is really no reason to reply. You might be overestimating the number of people that are interested in your choice of editors.
Marc gave an explanation of his improvements to netrexx-mode.el in an email, so your second line is also wide off the mark.

Please stop this behaviour; it might give new users a bad impression of the quality of this list.

best regards,

René Jansen.


On 18 jan. 2012, at 23:13, Thomas Schneider wrote:

> Hello Marc,
>   1.) thanks for your patch. As I don't use Emacs, I currently cannot use it.
>   2.) would you mind, next time, to give a two-line description what you're doing there?
>
> Greetings, and thanks in advance,
> Thomas.
> =========================================================================
> Am 18.01.2012 22:32, schrieb Marc Simpson:
>> On Wed, Jan 18, 2012 at 11:26 AM, Marc Simpson<[hidden email]>  wrote:
>>> Hi all,
>>>
>>> I'd like to submit a simple patch for the latest revision (r188) of
>>> netrexx-mode.el. It addresses the following issues,
>>> [...]
>> Slightly improved version here: http://pastebin.com/fbTA2GWB
>>
>> M
>>
>> _______________________________________________
>> Ibm-netrexx mailing list
>> [hidden email]
>> Online Archive : http://ibm-netrexx.215625.n3.nabble.com/
>>
>>
>
>
> --
> Thomas Schneider (Founder of www.thsitc.com) Member of the Rexx Languge Asscociation (www.rexxla.org) Member of the NetRexx Developer's Team (www.netrexx.org)
>
> _______________________________________________
> Ibm-netrexx mailing list
> [hidden email]
> Online Archive : http://ibm-netrexx.215625.n3.nabble.com/
>

_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/

[Marc Simpson]

On Wed, Jan 18, 2012 at 11:23 PM, René Jansen <[hidden email]> wrote:
> Hi Marc,
>
> as I almost exclusively edit NetRexx using Emacs, I am very interested in using this improvement. Could you send me a private email with the whole file attached?

Sure thing, sending now.

Best,
M


_______________________________________________
Ibm-netrexx mailing list
[hidden email]
Online Archive : http://ibm-netrexx.215625.n3.nabble.com/